Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: deploy using the shared deploy script and EXTRA_FILES #82

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 28, 2017

Depends on whatwg/whatwg.org#68.

The generic deploy.sh already runs the HTML checker, so those bits can be removed from .travis.yml too.

@foolip foolip requested a review from annevk August 29, 2017 08:13
@foolip
Copy link
Member Author

foolip commented Aug 29, 2017

This is now ready for review. It'll probably need some fixes after merging, so I'll check to see if it's working.

@foolip
Copy link
Member Author

foolip commented Aug 29, 2017

Actually, perhaps best discuss alternatives in whatwg/meta#11 (comment) first.

@foolip
Copy link
Member Author

foolip commented Aug 29, 2017

The Travis status checks in this very PR have confirmed that this is working at least a little:
https://compat.spec.whatwg.org/branch-snapshots/use-common-deploy/
https://compat.spec.whatwg.org/branch-snapshots/use-common-deploy/stroked-text.png

As @domenic suggested, we can just keep the EXTRA_FILES mechanism alongside something fancier, as it'll suffice for many cases.

@foolip foolip force-pushed the use-common-deploy branch from 4dc546c to 50eb7cd Compare August 29, 2017 20:01
@annevk
Copy link
Member

annevk commented Aug 30, 2017

In principle this looks fine, but it fails Travis.

foolip added a commit to whatwg/whatwg.org that referenced this pull request Aug 30, 2017
In a case like whatwg/compat#82 it's not easy
to tell how far into deploy.sh we got, this should help.
foolip added a commit to whatwg/whatwg.org that referenced this pull request Aug 30, 2017
In a case like whatwg/compat#82 it's not easy
to tell how far into deploy.sh we got, this should help.
@foolip foolip force-pushed the use-common-deploy branch from 50eb7cd to 92baf80 Compare August 30, 2017 08:05
annevk pushed a commit to whatwg/whatwg.org that referenced this pull request Aug 30, 2017
In a case like whatwg/compat#82 it's not easy
to tell how far into deploy.sh we got, this should help.
Depends on whatwg/whatwg.org#68.

The generic deploy.sh already runs the HTML checker, so those bits can
be removed from .travis.yml too.
@foolip foolip force-pushed the use-common-deploy branch from 92baf80 to a54bcb1 Compare August 30, 2017 08:37
@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

Looks like I force pushed over the HTML checker changes I made yesterday. I've restored those now, and with the other changes here and in deploy.sh, Travis is now happy.

@annevk annevk merged commit d3d7426 into master Aug 30, 2017
@foolip foolip deleted the use-common-deploy branch August 30, 2017 09:08
foolip added a commit that referenced this pull request Aug 31, 2017
foolip added a commit that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants