-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: deploy using the shared deploy script and EXTRA_FILES #82
Conversation
This is now ready for review. It'll probably need some fixes after merging, so I'll check to see if it's working. |
Actually, perhaps best discuss alternatives in whatwg/meta#11 (comment) first. |
0dcbcd9
to
4dc546c
Compare
The Travis status checks in this very PR have confirmed that this is working at least a little: As @domenic suggested, we can just keep the EXTRA_FILES mechanism alongside something fancier, as it'll suffice for many cases. |
4dc546c
to
50eb7cd
Compare
In principle this looks fine, but it fails Travis. |
In a case like whatwg/compat#82 it's not easy to tell how far into deploy.sh we got, this should help.
In a case like whatwg/compat#82 it's not easy to tell how far into deploy.sh we got, this should help.
50eb7cd
to
92baf80
Compare
In a case like whatwg/compat#82 it's not easy to tell how far into deploy.sh we got, this should help.
Depends on whatwg/whatwg.org#68. The generic deploy.sh already runs the HTML checker, so those bits can be removed from .travis.yml too.
92baf80
to
a54bcb1
Compare
Looks like I force pushed over the HTML checker changes I made yesterday. I've restored those now, and with the other changes here and in deploy.sh, Travis is now happy. |
Depends on whatwg/whatwg.org#68.
The generic deploy.sh already runs the HTML checker, so those bits can be removed from .travis.yml too.