Add proxy support (http_proxy and https_proxy env vars)
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
hey @whatthewhat! Is there anything I can do to improve this PR to get it merged? |
|
Sorry @saks, I just got back from vacation. Looks like testing this can be a challenge - I'll dig around for some options, but seems safe enough to merge as is if there aren't good ones. |
|
hey @whatthewhat! Thanks for looking into it. Please let me know if you need a hand with this. |
|
I think this is good to go as is for now. After reading how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Please have a look at this PR :)
After looking into docs one more time I figured how to make it look into ENV vars, thanks :)
I'm having issues figuring out how to write a test for my change, I'd very much appreciate any help here.
Please let me know what you think.
We've tested this change in our environment and everything seems working as expected.
Thanks!