Update the spec according to the new feedback #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the PR according to the feedback from several folks.
EdgeInterpolation
back toEdges
since the explanation in comments already made it clear and we don't have to use the long name any more.Covering
statistics since it is not really useful at the moment. Neither C++ and Java POC implement it.westmost
andeastmost
representation of BBox when edges = spherical.optional list<KeyValue> key_value_metadata
. This makes sure that the geometry column definition is clear.With this PR in place, the Parquet Geometry PR is nearly identical to the Iceberg Geometry PR, with the following exceptions:
lower_bounds
andupper_bounds
instead ofBBox
statistics. But it could easily adoptwestmost
andeastmost
representation by updating the spec explanation.If additional geometry column field like
orientation
is needed, we can add it to both Iceberg and Parquet Geometry PR but we should not allow list for arbitrary fields.