UUID rename #675
Merged
UUID rename #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandgeider
requested changes
May 9, 2021
|
it seems the linter is failing, the line with the suffix is longer than 100 characters. If you fix that I can merge this |
Linting problem fixed
|
Should be good to go now, linter ran clean for me in terminal. |
rolandgeider
approved these changes
May 9, 2021
|
Thanks, merged This was your first or right? In that case congratulations! |
|
Thank you, yes first ever PR! So very appreciative of your guidance, thanks for using good-first-issue tag as well it's how I found you guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Please check that the PR fulfills these requirements
flake8 --config .github/linters/.flake8 ./wger)and isort (
isort)Other questions
what changes might users need to make in their running application due to
this PR?) - No.