Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace psycopg2-binary with psycopg2 #1217

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Conversation

bbkz
Copy link
Contributor

@bbkz bbkz commented Jan 3, 2023

Proposed Changes

  • Although the arm64 image builds, django will crash because the psycopg2-binary is buggy (linked to the wrong library)
  • To be able to fix this compiling psycopg2 during image build will do

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features) -> not in django
  • Added yourself to AUTHORS.rst -> no changes in django code

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)? -> No

@bbkz
Copy link
Contributor Author

bbkz commented Jan 3, 2023

I was focused on my use case using docker images, i am not sure what implication this will have on "normally" installed setups. They may need to install the libpq5 package with their package manager.

@rolandgeider
Copy link
Member

Good catch!

Would it make sense to add a requirements_docker.txt for this?

@bbkz
Copy link
Contributor Author

bbkz commented Jan 5, 2023

I am not (hin-und-her gerissen) not sure. It would require not to forget to keep them in sync when the requirements changes. Also when someone want's to install it directly on arm (raspberry pi), it would still fail.

I never tried a "non" docker setup but according to the documentation i like the fact that currently only python packages trough pip are required.

@bbkz
Copy link
Contributor Author

bbkz commented Jan 7, 2023

I have added a requirements_docker.txt.

@rolandgeider rolandgeider merged commit 27cbaa1 into wger-project:master Jan 26, 2023
@rolandgeider rolandgeider added this to the 2.2 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants