Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 1124] Adds full imperial unit functionality to BMI Calculator #1185

Merged
merged 12 commits into from
Nov 23, 2022
Merged

[Issue 1124] Adds full imperial unit functionality to BMI Calculator #1185

merged 12 commits into from
Nov 23, 2022

Commits on Nov 14, 2022

  1. Implementing AbstractHeight helper class and adding call to it in BMI… 

    … calculator when imperial units are selected.
    @berniekoen
    berniekoen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b43be61 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Adapt form validation to recognize user unit preferences.

    @berniekoen
    berniekoen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    99537b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Added appropriate labels based on units to BMI calculator on page ren… 

    …der.
    @berniekoen
    berniekoen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    f7eda05 View commit details
    Browse the repository at this point in the history

  2. Added error messages when the user inputs an out of range height.

    @berniekoen
    berniekoen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    053210a View commit details
    Browse the repository at this point in the history

  3. Adapt existing imperial test to take in proper units for height.

    @berniekoen
    berniekoen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    354b5df View commit details
    Browse the repository at this point in the history

  4. Added and adapted tests to test functionality and error messages and … 

    …error status codes.
    @berniekoen
    berniekoen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6de5557 View commit details
    Browse the repository at this point in the history

  5. Added myself to authors.RST

    @berniekoen
    berniekoen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    f2b2bca View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Added Gabe Liss to Authors

    @berniekoen
    berniekoen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    57acaaf View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Mark strings with _() format to indicate need for translation

    @berniekoen
    berniekoen committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    fa565d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Get rid of _

    @berniekoen
    berniekoen committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    dce0038 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_1124

    @bernardokoen
    bernardokoen authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    e1c97df View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Add gettext translation import

    @berniekoen
    berniekoen committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    eacc254 View commit details
    Browse the repository at this point in the history