Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'gd' does not support git move/rename actions #188

Closed
5 of 10 tasks
carlfriedrich opened this issue Mar 11, 2022 · 1 comment
Closed
5 of 10 tasks

'gd' does not support git move/rename actions #188

carlfriedrich opened this issue Mar 11, 2022 · 1 comment
Assignees

Comments

@carlfriedrich
Copy link
Collaborator

Check list

  • I have read through the README
  • I have the latest version of forgit
  • I have searched through the existing issues

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

The forgit::diff function aka gd does not support git move or rename actions. Minimal reproducible example:

mkdir myrepo
cd myrepo
git init
echo "wow" > foo.txt
git add foo.txt
git commit -m "Commit 1"
git mv foo.txt bar.txt
echo "oh" > baz.txt
git add baz.txt

Calling gd --staged on this repo shows the following:

grafik

Obviously the output of git diff --name-status is not correctly parsed.

@carlfriedrich carlfriedrich mentioned this issue Mar 11, 2022
13 tasks
@carlfriedrich
Copy link
Collaborator Author

@wfxr I made PR #189 to fix this. Please let me know if it can be merged.

@wfxr wfxr closed this as completed in 5093c18 Mar 21, 2022
@cjappl cjappl mentioned this issue Mar 21, 2022
15 tasks
cjappl added a commit that referenced this issue Mar 21, 2022
Checked in a bunch of things that were only for bash #189 #186 #185 #190 #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants