Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack config from svelte webpack template #6

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add webpack config from svelte webpack template #6

merged 1 commit into from
Apr 2, 2020

Conversation

JoshuaCrewe
Copy link
Contributor

This commit takes configuration found in the official svelte webpack template and includes it in this extension. The configuration is specific to svelte development and appears to reduce bugs introduced from including thirds party svelte libraries.

Aims to fix issue #5 .

This commit takes configuration found in the official svelte webpack
template and includes it in this extension. The configuration is
specific to svelte development and appears to reduce bugs introduced
from including thirds party svelte libraries.
@JoshuaCrewe
Copy link
Contributor Author

Lines 27-33 is the configuration which fixes issue #5 . The default webpack behaviour is mainFields: ['browser', 'module', 'main']

The rest of this PR adds configuration found in the Svelte Webapck template. These are not needed for the fix but have been included for completeness.

It is nice to not have to include .svelte in imports and the alias fixes bugs arising from linking modules I think.

@morpheus7CS morpheus7CS merged commit 48f352d into wewowweb:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants