Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone + Number fields used on vanilla wework.com #81

Open
i8ramin opened this issue May 9, 2019 · 1 comment
Open

Phone + Number fields used on vanilla wework.com #81

i8ramin opened this issue May 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@i8ramin
Copy link
Contributor

i8ramin commented May 9, 2019

Screen Shot 2019-05-09 at 11 05 05 AM

Would be nice to add the Phone and Number Selector inputs that are currently used on wework.com to Ray. I know that the Phone one isn't the best implementation and there is room for improvement, but the lack of any support in Ray right now leaves it up to each team to copy/paste whats there vs consolidating it all in one place (so we can easily replace it later)
@i8ramin i8ramin added the enhancement New feature or request label May 9, 2019
i8ramin pushed a commit that referenced this issue May 9, 2019
feat(component): prepend support on textfield & select
8bf5131 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
@i8ramin i8ramin mentioned this issue May 9, 2019
Merged
i8ramin pushed a commit that referenced this issue May 11, 2019
feat(component): prepend support on textfield & select
e9ef9d6 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
i8ramin pushed a commit that referenced this issue May 17, 2019
feat(component): prepend support on textfield & select
3166682 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
i8ramin pushed a commit that referenced this issue May 20, 2019
feat(component): prepend support on textfield & select
3c2e9af 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
i8ramin pushed a commit that referenced this issue May 24, 2019
feat(component): prepend support on textfield & select
eeaac85 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
i8ramin pushed a commit that referenced this issue May 28, 2019
feat(component): prepend support on textfield & select
d1efe84 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
i8ramin added a commit that referenced this issue May 28, 2019
@i8ramin
feat(component): prepend support on textfield & select (#82)
ea1f00e 
BREAKING CHANGE: textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
adamraider pushed a commit that referenced this issue May 29, 2019
@i8ramin
feat(component): prepend support on textfield & select (#82)
5d7bce6 
textfields and selects that have icons (and not prepends) need to be wrapped in an
extra div with a class name of "#{$ray-class-prefix}#{$class}__wrapper"

re #81
@adamraider
Copy link
Contributor

Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i8ramin @adamraider