Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump Metamask SDK version to fix webpack dynamic import issue #4433

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

Aerilym
Copy link
Contributor

@Aerilym Aerilym commented Dec 1, 2024

Bumps the metamask sdk version to 0.31.1 to fix the webpack dynamic import issue. Metamask SDK 0.31.0 has this issue and prevents @wagmi/connector from working in nextjs. See the next playground example on main to see the error. MetaMask/metamask-sdk#1150

fixes #4432

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: 882c828

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@wagmi/connectors Patch
wagmi Patch
@wagmi/core Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 0:24am

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] environment, filesystem, network Transitive: eval, shell +64 34.7 MB metamaskbot

View full report↗︎

@Aerilym
Copy link
Contributor Author

Aerilym commented Dec 1, 2024

Ideally this issue shouldn't have made it onto main, bumping the Metamask SDK version to 0.31.0 in #4422 caused this issue as there was a bug in that version of the Metamask SDK that prevented building with Webpack, breaking Nextjs. I'm able to reproduce this by simply running the next playground example, causing an immediate build error. Perhaps running the playground examples should be a requirement when bumping package version (or just generally).

In the long run, writing basic automated tests to boot up the playgrounds and use the basic functionality would be sufficient to prevent breaking end user apps in the future. If there's interest in going in this direction I'd be happy to look into it.

Actually, even just adding building the playgrounds to the CI and requiring they pass would prevent this in the future.

@elix1er
Copy link

elix1er commented Dec 1, 2024

BUMP! please merge!

@jxom jxom merged commit 06e186c into wevm:main Dec 1, 2024
3 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Dec 1, 2024
@elix1er
Copy link

elix1er commented Dec 2, 2024

ETA release please

@jxom
Copy link
Member

jxom commented Dec 2, 2024

Please don’t spam these threads. Nothing is stopping you from doing an npm override.

@wevm wevm locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@wagmi/connectors incompatable metamask sdk version causes "Module Parse Failed" in Nextjs
3 participants