-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bump Metamask SDK version to fix webpack dynamic import issue #4433
fix: Bump Metamask SDK version to fix webpack dynamic import issue #4433
Conversation
🦋 Changeset detectedLatest commit: 882c828 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Ideally this issue shouldn't have made it onto main, bumping the Metamask SDK version to 0.31.0 in #4422 caused this issue as there was a bug in that version of the Metamask SDK that prevented building with Webpack, breaking Nextjs. I'm able to reproduce this by simply running the next playground example, causing an immediate build error. Perhaps running the playground examples should be a requirement when bumping package version (or just generally). In the long run, writing basic automated tests to boot up the playgrounds and use the basic functionality would be sufficient to prevent breaking end user apps in the future. If there's interest in going in this direction I'd be happy to look into it. Actually, even just adding building the playgrounds to the CI and requiring they pass would prevent this in the future. |
BUMP! please merge! |
ETA release please |
Please don’t spam these threads. Nothing is stopping you from doing an npm override. |
Bumps the metamask sdk version to 0.31.1 to fix the webpack dynamic import issue. Metamask SDK 0.31.0 has this issue and prevents @wagmi/connector from working in nextjs. See the next playground example on main to see the error. MetaMask/metamask-sdk#1150
fixes #4432