Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set cookie path correctly #4188

Closed
wants to merge 1 commit into from

Conversation

goosewobbler
Copy link

The path of the shimDisconnect cookie is being defaulted in all cases to /, this means that when wagmi is re-connected on the page /a/b/c, the cookie is not removed. By setting the cookie path to /a/b upon disconnect, the cookie is recognised when the app is re-connected.

Fixes #4097

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: e54d7b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:54pm

@tmm
Copy link
Member

tmm commented Aug 6, 2024

Thanks for the PR! This doesn't quite fix the issue as path=/ is what we want so the cookie works on all paths under the domain. Instead removeItem needed path added to it.

@tmm tmm closed this Aug 6, 2024
@goosewobbler
Copy link
Author

goosewobbler commented Aug 7, 2024

Makes sense, I was close but no cigar.

@tmm
Copy link
Member

tmm commented Aug 7, 2024

Next time my friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnected session cookie not removed after connecting again
2 participants