export signTransaction, update docs #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55ccd86 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@holic is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
holic
commented
Aug 4, 2023
site/docs/accounts/custom.md
Outdated
| @@ -25,10 +25,9 @@ import { toAccount } from 'viem/accounts' | |||
| ## Usage | |||
|
|
|||
| ```ts | |||
| import { createWalletClient, http } from 'viem' | |||
| import { toAccount } from 'viem/accounts' // [!code focus] | |||
| import { createWalletClient, getAddress, http } from 'viem' | |||
There was a problem hiding this comment.
I moved getAddress to a real import but this doesn't actually work for turning a private key into an address. Does viem need a helper for this?
There was a problem hiding this comment.
Could be worth adding a privateKeyToAddress util that just composes this. Similar to publicKeyToAddress.
Merged
aaronmgdr
pushed a commit
to celo-org/viem
that referenced
this pull request
Aug 18, 2023
) * export signTransaction * update docs * refactor --------- Co-authored-by: moxey.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
Focus of this PR:
This PR focuses on adding new exports to the
viem/accountsentrypoint, specificallysignTransactionandprivateKeyToAddress.Detailed summary:
signTransactionandprivateKeyToAddressexports toviem/accountsentrypoint.site/docs/accounts/signMessage.mdandsite/docs/accounts/signTypedData.md.privateKeyToAddressinsrc/accounts/utils/privateKeyToAddress.test.ts.src/accounts/utils/signTransaction.tsto useSignTransactionParameterstype.site/docs/accounts/custom.mdandsite/docs/accounts/signTransaction.md.privateKeyToAddressexport tosrc/accounts/index.ts.