feat: ens actions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c210c87 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.73 kB (+5%) 🔍 Total Size: 36.6 kB
ℹ️ View Unchanged
|
tmm
commented
Feb 10, 2023
tmm
commented
Feb 10, 2023
jxom
reviewed
Feb 10, 2023
| test('name without address', async () => { | ||
| await expect( | ||
| getEnsAddress(publicClient, { | ||
| name: 'unregistered-name.eth', |
There was a problem hiding this comment.
Should we throw for non-existent names?
jxom
force-pushed
the
tmm/ens-actions
branch
from
66de464
to
6d67a0a
Compare
jxom
force-pushed
the
tmm/ens-actions
branch
2 times, most recently
from
b8cca5d
to
309979f
Compare
jxom
force-pushed
the
tmm/ens-actions
branch
from
309979f
to
71f3402
Compare
jxom
force-pushed
the
tmm/ens-actions
branch
from
71f3402
to
517386b
Compare
tmm
commented
Feb 11, 2023
Comment on lines
+98
to
+100
| "isomorphic-unfetch": "^4.0.2", | ||
| "isomorphic-ws": "^5.0.0", | ||
| "ws": "^8.12.0" |
jxom
force-pushed
the
tmm/ens-actions
branch
from
1716d5a
to
c210c87
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ENS actions