feat: add ability to hash data representation of message #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6fc2f08 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +454 B (0%) Total Size: 254 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #610 +/- ##
==========================================
- Coverage 99.92% 99.91% -0.02%
==========================================
Files 259 259
Lines 24151 24173 +22
Branches 2006 2013 +7
==========================================
+ Hits 24134 24153 +19
- Misses 17 20 +3
|
|
this is great! thanks for tackling this so quickly |
Co-authored-by: moldy <[email protected]>
jxom
force-pushed
the
jxom/hash-data-message
branch
from
d87ab3a to
0d00189
Compare
Merged
jxom
added a commit
that referenced
this pull request
Jun 2, 2023
* feat: add ability to hash data representation of message Co-authored-by: moldy <[email protected]> * chore: changeset * feat: ethers adapter --------- Co-authored-by: moldy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds the ability to hash data representation of messages in sign, verify, and recover functions. It also updates related functions to accept a
SignableMessagetype instead of a string.Detailed summary
SignableMessagetype tomisc.tsrawattribute toSignableMessagesignMessage,verifyMessage, andrecoverMessageAddressto acceptSignableMessagehashMessageto acceptSignableMessagehashMessageverifyMessageto acceptSignableMessageand adds example for usingrawattribute in verificationethersWalletToAccountto supportSignableMessageinsignMessagesignMessageto supportSignableMessageand adds example for usingrawattribute in signingSignableMessageand testrawattribute