Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retries to waitForTransactionReceipt #470

Merged
merged 1 commit into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-foxes-reply.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"viem": patch
---

Fixed issue where `waitForTransactionReceipt` would throw immediately for RPC Providers which may be slow to sync mined transactions.
4 changes: 3 additions & 1 deletion src/actions/public/waitForTransactionReceipt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export async function waitForTransactionReceipt<
let transaction: GetTransactionReturnType<TChain> | undefined
let replacedTransaction: GetTransactionReturnType<TChain> | undefined
let receipt: GetTransactionReceiptReturnType<TChain>
let retries = 0

return new Promise((resolve, reject) => {
if (timeout)
Expand Down Expand Up @@ -219,7 +220,8 @@ export async function waitForTransactionReceipt<
emit.resolve(receipt)
})
} else {
done(() => emit.reject(err))
if (retries > 2) done(() => emit.reject(err))
retries++
}
}
},
Expand Down