fix: skip invalid logs

[jxom]

Fixes #323.

• Skips event logs that do not conform to the given ABI filter
• Adds better error messaging for when ABI decoding data size is too short
• Adds better error messaging for when there is a mismatch between non-indexed arguments in the event ABI

[changeset-bot]

🦋 Changeset detected

Latest commit: 285b943

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
viem	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2023 1:12am
viem-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2023 1:12am

[pr-codex]

Tldr

This PR fixes an issue where filtered logs that do not conform to the provided ABI would cause getLogs, getFilterLogs or getFilterChanges to throw. These logs are now skipped.

Detailed summary

• A new file ERC20InvalidTransferEvent.sol is added.
• A new function deployErc20InvalidTransferEvent() is added in utils.ts.
• The getFilterChanges() and getFilterLogs() functions in getFilterChanges.ts and getFilterLogs.ts respectively, have been modified to skip logs which do not conform to the provided ABI.
• Tests are added for the new contract and for skipping invalid logs.

[github-actions]

Size Change: +364 B (+1%)

Total Size: 57 kB

Filename	Size	Change
dist/abi.js	257 B	+1 B (0%)
dist/accounts/index.js	1.37 kB	+3 B (0%)
dist/chains.js	2.03 kB	-1 B (0%)
dist/chunk-6PP4CMLN.js	0 B	-43 kB (removed)	🏆
dist/chunk-I2RHOQQS.js	0 B	-415 B (removed)	🏆
dist/contract.js	438 B	-1 B (0%)
dist/ens.js	339 B	+2 B (+1%)
dist/ethers.js	755 B	+2 B (0%)
dist/index.js	5.54 kB	+1 B (0%)
dist/utils/index.js	1.2 kB	+6 B (+1%)
dist/wallet.js	294 B	+1 B (0%)
dist/chunk-DT4KSXZC.js	416 B	+416 B (new file)	🆕
dist/chunk-QITZHDNP.js	43.3 kB	+43.3 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
dist/public.js	456 B
dist/test.js	506 B
dist/window.js	67 B

_{compressed-size-action}

[codecov]

Codecov Report

Merging #326 (285b943) into main (cfa1224) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #326    +/-   ##
========================================
  Coverage   99.86%   99.86%            
========================================
  Files         263      263            
  Lines       16899    17015   +116     
  Branches     1805     1819    +14     
========================================
+ Hits        16876    16992   +116     
  Misses         21       21            
  Partials        2        2            

Impacted Files	Coverage Δ
src/actions/public/getFilterChanges.ts	100.00% <100.00%> (ø)
src/actions/public/getFilterLogs.ts	100.00% <100.00%> (ø)
src/actions/public/getLogs.ts	100.00% <100.00%> (ø)
src/errors/abi.ts	100.00% <100.00%> (ø)
src/errors/index.ts	100.00% <100.00%> (ø)
src/utils/abi/decodeAbiParameters.ts	100.00% <100.00%> (ø)
src/utils/abi/decodeEventLog.ts	99.24% <100.00%> (+0.07%)	⬆️
src/utils/abi/formatAbiItem.ts	100.00% <100.00%> (ø)
src/utils/abi/index.ts	100.00% <100.00%> (ø)
src/utils/index.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.