Fix getUserOperationError for UserOp execution reverted 0x
#2879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function,
getUserOperationError
has run time error when processing UserOperationError:UserOperation reverted during simulation with reason: 0x
. Please refer to the following capture.Error
Even though this is unknown contract execution reverted error, it should be displaying the original error instead of this runtime issue, which leads to some confusion for debugging.
This PR includes a very small fix in
getUserOperationError
function which validates thecalls
values from function input before proceeding to determine the contract call data.To reproduce the error
Test input
Expected
It should return the original error message (
UserOperation reverted during simulation with reason: 0x
) with theUserOperation
object provided to the RPC call.PR-Codex overview
This PR focuses on fixing a runtime error in the
getUserOperationError
function by adding a condition to check forcalls
and enhancing the test coverage for scenarios where execution is reverted without calls.Detailed summary
getUserOperationError
by adding a check forcalls
.getUserOperationError
to handle the case of execution reverted without calls.RpcRequestError
occurs.