fix: narrow sign transaction return type based on the transaction type #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marthendalnunes is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: a5bc63b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Can we add a type test for this under |
|
sure, I'll add it |
|
Added the type tests and refactored the return type narrowing to infer the transaction type based on the whole request object rather than only the type key. |
jxom
force-pushed
the
fix/sign-transaction-return-type
branch
from
a8d7cb4
to
a5bc63b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on narrowing the return type of the
signTransactionfunction in the wallet client, enhancing type safety and ensuring more precise types for transaction requests.Detailed summary
signTransactionto be more specific based on the request type.signTransactionparameters to include a default request type.legacy,eip1559,eip2930,eip4844,eip7702) to validate type expectations.pnpm-lock.yamlto reflect the new version ofviem.