fix: narrow sign transaction return type based on the transaction type #2853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on narrowing the return type of the
signTransaction
function in the wallet client, enhancing type safety and ensuring more precise types for transaction requests.Detailed summary
signTransaction
to be more specific based on the request type.signTransaction
parameters to include a default request type.legacy
,eip1559
,eip2930
,eip4844
,eip7702
) to validate type expectations.pnpm-lock.yaml
to reflect the new version ofviem
.