Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if parameters have gas fees first #2850

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

plusminushalf
Copy link
Contributor

@plusminushalf plusminushalf commented Oct 13, 2024

This PR fixes the issue where prepareUserOperation overrides the gas field that are already present in the user operation.


PR-Codex overview

This PR focuses on updating the handling of user-defined fee parameters in the prepareUserOperation function to improve the precedence of these parameters.

Detailed summary

  • Updated the precedence of user-defined fee parameters in prepareUserOperation.
  • Removed redundant check for sufficient fee properties before returning the request.
  • Retained the logic to estimate fees if user-defined properties are not sufficient.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 13, 2024

🦋 Changeset detected

Latest commit: fd8cd06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 13, 2024

@plusminushalf is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit 9e26e16 into wevm:main Oct 13, 2024
12 of 24 checks passed
@github-actions github-actions bot mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants