Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pre fp withdrawal error status to return ready-to-prove #2747

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

nitaliano
Copy link
Contributor

@nitaliano nitaliano commented Sep 19, 2024

Fixes bug in getWithdrawalStatus for pre fault proof withdrawals.

The status function wasn't handling this error and when we encounter this error we want to return ready-to-prove

Tested against this hash 0xd45b140c2240ec54153cce72e2176cd0d263a9fbf81620b09dcc9a19faa92c15


PR-Codex overview

This PR focuses on fixing a bug in the getWithdrawalStatus function in the OP Stack related to pre fault-proof withdrawals.

Detailed summary

  • Fixed bug in getWithdrawalStatus for pre fault-proof withdrawals
  • Updated error message conditions in getWithdrawalStatus.ts file
  • Added handling for new error message condition in getWithdrawalStatus.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: f5abb53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 19, 2024

@nitaliano is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@nitaliano nitaliano force-pushed the bugfix/fix-op-pre-fp-withdrawal-status branch from c76bbb5 to b294503 Compare September 19, 2024 20:09
@nitaliano nitaliano marked this pull request as ready for review September 19, 2024 20:23
@nitaliano nitaliano changed the title Update pre fp withdrawal error status to return ready-to-prove Fixes pre fp withdrawal error status to return ready-to-prove Sep 19, 2024
@jxom jxom merged commit ce6a84d into wevm:main Sep 19, 2024
12 of 25 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
@nitaliano nitaliano deleted the bugfix/fix-op-pre-fp-withdrawal-status branch September 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants