Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump hono #354

Merged
merged 7 commits into from
Jun 10, 2024
Merged

chore: bump hono #354

merged 7 commits into from
Jun 10, 2024

Conversation

dalechyn
Copy link
Collaborator

@dalechyn dalechyn commented Jun 9, 2024

Closes #336.

Should have been fixed by honojs/hono@5bd2b71 in honojs/hono#2662.

@dalechyn dalechyn requested a review from tmm June 9, 2024 23:04
@dalechyn dalechyn self-assigned this Jun 9, 2024
Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:59am
frog-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:59am
frog-frame ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:59am

Copy link

socket-security bot commented Jun 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 888 kB yusukebe

🚮 Removed packages: npm/[email protected]

View full report↗︎

@dalechyn
Copy link
Collaborator Author

dalechyn commented Jun 9, 2024

@tmm, what do you think about both exporting JSX type and declaring it globally?
I don't know what's the original reason behind moving from global declaration but it seems that exporting JSX type was the missing piece to make ts work.

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM->Vercel template has incorrect typings issue
2 participants