fix(zod): allow empty string on name property in AbiParameter (#185)

* fix: allow empty name in AbiParameter * chore: update changeset --------- Co-authored-by: 0xRaiden <[email protected]>
wevm · Aug 17, 2023 · f5b27a8 · f5b27a8 · vercel · Aug 17, 2023
1 parent b03440c
commit f5b27a8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/large-pugs-add.md b/.changeset/large-pugs-add.md
@@ -0,0 +1,5 @@
+---
+"abitype": patch
+---
+
+Fixed a bug where an empty string on the `name` property in AbiParameter wasn't allowed.
diff --git a/src/zod.test.ts b/src/zod.test.ts
@@ -611,10 +611,12 @@ describe('AbiParameter', () => {
   it('returns valid schema', () => {
     expect(
       AbiParameter.parse({
+        name: '',
         type: 'address',
       }),
     ).toMatchInlineSnapshot(`
       {
+        "name": "",
         "type": "address",
       }
     `)

diff --git a/src/zod.ts b/src/zod.ts
@@ -52,7 +52,7 @@ export const SolidityArray = z.union([
 export const AbiParameter: z.ZodType<AbiParameterType> = z.lazy(() =>
   z.intersection(
     z.object({
-      name: Identifier.optional(),
+      name: z.union([Identifier.optional(), z.literal('')]),
       /** Representation used by Solidity compiler */
       internalType: z.string().optional(),
     }),