release: v3.0.5 #165
Merged
release: v3.0.5 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(issue#152) renamed the classnames.tsx to classnames.ts
🦋 Changeset detectedLatest commit: b6651f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
(components/docs) fix: navigation docs and exports
fix(issue#157) added 0 to SpacingRange type
liamegan
approved these changes
Apr 15, 2024
| @@ -5,7 +5,7 @@ const TOTAL_SPACE_CLASSES = 10 | |||
| const BREAKPOINTS: Exclude<Breakpoint, "sm">[] = ["md", "lg", "xl", "xxl"] | |||
|
|
|||
| // This should be the same amount as TOTAL_SPACE_CLASSES | |||
| type SpacingRange = 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | |||
| type SpacingRange = 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | |||
There was a problem hiding this comment.
I wish TS supported range definitions.
There was a problem hiding this comment.
Me too. There is a proposal being worked on, so hopefully soon 🙏
microsoft/TypeScript#43505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #152 with #164
Fix #158 with #160
To-Do