Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text correction in Global footer -> WET-487 #2437

Closed
wants to merge 0 commits into from
Closed

Text correction in Global footer -> WET-487 #2437

wants to merge 0 commits into from

Conversation

SebastianBurke
Copy link
Contributor

Money and finance -> Money and finances
Argent et finance -> Argent et finances

Garneauma
Garneauma requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianBurke Please update the documentation. This will be a major version. Let me know if you have any question.

@duboisp duboisp added this to the v16.0.0 milestone Nov 1, 2024
@Garneauma Garneauma self-assigned this Nov 4, 2024
Garneauma
Garneauma requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the version 7.0 changes at the top of "old-footers-en/fr.html" with a working example. You can simply copy the working example from version 6.0 and apply the change made in 7.0. The working example should be placed under the "deprecated" folder.

Garneauma
Garneauma requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the below comments, there has been a new request (WET-497) to change the text for the link "Indigenous peoples" to "Indigenous Peoples". Please add this change to the current PR. Thank you.

sites/footers/deprecated/footers-v7-en.html Outdated Show resolved Hide resolved
sites/footers/deprecated/footers-v7-en.html Outdated
<li><a href="https://www.canada.ca/en/services/policing.html">Policing, justice and emergencies</a></li>
<li><a href="https://www.canada.ca/en/services/transport.html">Transport and infrastructure</a></li>
<li><a href="https://international.gc.ca/world-monde/index.aspx?lang=eng">Canada and the world</a></li>
<li><a href="https://www.canada.ca/en/services/finance.html">Money and finances</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="https://www.canada.ca/en/services/finance.html">Money and finances</a></li>
<li><a href="https://www.canada.ca/en/services/finance.html">Money and finance</a></li>

sites/footers/deprecated/footers-v7-fr.html Outdated
<li><a href="https://www.canada.ca/fr/services/police.html">Services de police, justice et urgences</a></li>
<li><a href="https://www.canada.ca/fr/services/transport.html">Transport et infrastructure</a></li>
<li><a href="https://www.international.gc.ca/world-monde/index.aspx?lang=fra">Le Canada et le monde</a></li>
<li><a href="https://www.canada.ca/fr/services/finance.html">Argent et finances</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="https://www.canada.ca/fr/services/finance.html">Argent et finances</a></li>
<li><a href="https://www.canada.ca/fr/services/finance.html">Argent et finance</a></li>

sites/footers/footers-fr.md Outdated Show resolved Hide resolved
sites/footers/old-footers-en.html Outdated Show resolved Hide resolved
Garneauma
Garneauma requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianBurke I think you got the version mixed up. Here's the list of versions and their changes. Please make sure the working examples in the deprecated folder and the code samples reflect those changes.

The main documentation page should reflect version 8.0 and it lists the changes since version 4.0 as they were all minor stuff.

The "old-footers" pages document the versions 7.0 and older.

Version 8.0: Money and finances, and Indigenous Peoples
Version 7.0 : Added “www.” to the “Canada and the world” URL.
Version 6.0 : Changed the “Veterans and military” URL.

sites/footers/footers-fr.md Outdated
@@ -32,7 +32,7 @@ Consultez le système de conception de Canada.ca pour savoir quels éléments de
### Version 7.0

Les modifications suivantes ont été apportées depuis la **version 4.0**&nbsp;:
* Version 7.0: Ajouté "www." à l'URL du lien "<span lang="en">Canada and the world</span>".
* Version 7.0 : Pluriel de "finance" dans "Argent et finance", mise en majuscule de "peoples" dans "Indigenous peoples", et ajout de "www." à l'URL de "Canada et le monde".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "www" was added at version 7 and these new changes are now version 8.

Suggested change
* Version 7.0 : Pluriel de "finance" dans "Argent et finance", mise en majuscule de "peoples" dans "Indigenous peoples", et ajout de "www." à l'URL de "Canada et le monde".
* Version 8.0 : Pluriel de "finance" dans "Argent et finance" et mise en majuscule de "<span lang="en">peoples</span>" dans "<span lang="en">Indigenous peoples</span>" dans la version anglaise.
* Version 7.0: Ajouté “www.” à l’URL du lien “<span lang="en">Canada and the world</span>”.

sites/footers/footers-en.md Outdated
@@ -32,7 +32,7 @@ Consult the Canada.ca Design System for guidance on which footer elements or cus
### Version 7.0

The following changes have been made since **version 4.0**:
* Version 7.0 : Added "www." to the "Canada and the world" URL.
* Version 7.0 : Pluralized "finance" in "Money and finance", capitalized "peoples" in "Indigenous peoples", and added "www." to the "Canada and the world" URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Version 7.0 : Pluralized "finance" in "Money and finance", capitalized "peoples" in "Indigenous peoples", and added "www." to the "Canada and the world" URL.
* Version 8.0 : Pluralized "finance" in "Money and finance" and capitalized "peoples" in "Indigenous peoples".
* Version 7.0 : Added “www.” to the “Canada and the world” URL.

sites/footers/old-footers-en.html Outdated
<li>Pluralized "finance" in "Money and finance"</li>
<li>Capitalized "peoples" in "Indigenous peoples"</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Pluralized "finance" in "Money and finance"</li>
<li>Capitalized "peoples" in "Indigenous peoples"</li>

sites/footers/old-footers-en.html Outdated
&lt;li>&lt;a href="https://www.international.gc.ca/world-monde/index.aspx?lang=eng">Canada and the world&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/finance.html">Money and finances&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/science.html">Science and innovation&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous Peoples&lt;/a>&lt;/li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&lt;li>&lt;a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous Peoples&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous peoples&lt;/a>&lt;/li>

sites/footers/old-footers-en.html Outdated
&lt;li>&lt;a href="https://www.canada.ca/en/services/policing.html">Policing, justice and emergencies&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/transport.html">Transport and infrastructure&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.international.gc.ca/world-monde/index.aspx?lang=eng">Canada and the world&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/finance.html">Money and finances&lt;/a>&lt;/li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&lt;li>&lt;a href="https://www.canada.ca/en/services/finance.html">Money and finances&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/en/services/finance.html">Money and finance&lt;/a>&lt;/li>

sites/footers/old-footers-fr.html Outdated
Comment on lines 18 to 94
<li>Pluriel de "finance" dans "Argent et finance"</li>
<li>Mise en majuscule de "peoples" dans "Indigenous peoples"</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Pluriel de "finance" dans "Argent et finance"</li>
<li>Mise en majuscule de "peoples" dans "Indigenous peoples"</li>

sites/footers/old-footers-fr.html Outdated
&lt;li>&lt;a href="https://www.canada.ca/fr/services/police.html">Services de police, justice et urgences&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/fr/services/transport.html">Transport et infrastructure&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.international.gc.ca/world-monde/index.aspx?lang=fra">Le Canada et le monde&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/fr/services/finance.html">Argent et finances&lt;/a>&lt;/li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&lt;li>&lt;a href="https://www.canada.ca/fr/services/finance.html">Argent et finances&lt;/a>&lt;/li>
&lt;li>&lt;a href="https://www.canada.ca/fr/services/finance.html">Argent et finance&lt;/a>&lt;/li>

sites/footers/old-footers-fr.html Outdated
"share": "true"
}
---
<div class="wb-prettify all-pre hide"></div>

<h2>Version 6.0</h2>
<h2>Version 7.0</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2>Version 7.0</h2>
<h2>Version 7.0 (deprecated)</h2>

sites/footers/deprecated/footers-v7-en.html Outdated
<li><a href="https://www.international.gc.ca/world-monde/index.aspx?lang=eng">Canada and the world</a></li>
<li><a href="https://www.canada.ca/en/services/finance.html">Money and finances</a></li>
<li><a href="https://www.canada.ca/en/services/science.html">Science and innovation</a></li>
<li><a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous Peoples</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous Peoples</a></li>
<li><a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous peoples</a></li>

@Garneauma Garneauma removed this from the v16.0.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garneauma Garneauma Garneauma requested changes

Assignees

@SebastianBurke SebastianBurke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianBurke @Garneauma @duboisp