Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 User test baselines have changed for fix-conditional-param-leak #55

Conversation

typescript-bot
Copy link

This test run was triggerd by a request on microsoft#31455
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham

@weswigham weswigham closed this Feb 27, 2020
weswigham pushed a commit that referenced this pull request Mar 29, 2021
* Added support for private identifier methods.

* Added tests for private methods.

* Added check to only not allow private name method signatures in anything except classes.
Changes objects literal checking to not bail on first private name found in object literal.

* Added private accessors tests

* Transform private methods

Signed-off-by: Kubilay Kahveci <[email protected]>

* Rename shouldTransformPrivateFields

Signed-off-by: Kubilay Kahveci <[email protected]>

* Accept baseline

Signed-off-by: Kubilay Kahveci <[email protected]>

* Use a single WeakSet for brand-check

Signed-off-by: Kubilay Kahveci <[email protected]>

* Accept baseline

Signed-off-by: Kubilay Kahveci <[email protected]>

* Add a test for using private methods in static field initializers

Signed-off-by: Kubilay Kahveci <[email protected]>

* Add breaking checker test

Private methods inside class expressions should not error.

Signed-off-by: Kubilay Kahveci <[email protected]>

* Add to instances once per-instance

Signed-off-by: Kubilay Kahveci <[email protected]>

* Accept baseline

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: evaluate receiver and rhs expressions before throwing on readonly assignment

Signed-off-by: Kubilay Kahveci <[email protected]>

* Add a test for evaluating rhs before readonly assignment

Signed-off-by: Kubilay Kahveci <[email protected]>

* Transpile private accessors

Signed-off-by: Kubilay Kahveci <[email protected]>

* Accept baseline

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: handle readonly/writeonly accessors

Signed-off-by: Kubilay Kahveci <[email protected]>

* accept baseline

Signed-off-by: Kubilay Kahveci <[email protected]>

* add a test for private setter without a getter

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: getAllUnscopedEmitHelpers

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: better handling of duplicate names

Signed-off-by: Kubilay Kahveci <[email protected]>

* Fixed wrong error message for private methods in class expressions.

* change error message

Signed-off-by: Kubilay Kahveci <[email protected]>

* add a test for async private methods with a higher target

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: setter assignment returns rhs value

Signed-off-by: Kubilay Kahveci <[email protected]>

* add a test for setter assignment return value

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: handle duplicate accessors

Signed-off-by: Kubilay Kahveci <[email protected]>

* add tests for duplicate accessors

Signed-off-by: Kubilay Kahveci <[email protected]>

* docs: add missing parameter docs

Signed-off-by: Kubilay Kahveci <[email protected]>

* Fixed failing test.

* baseline-accept: ordering changes

Signed-off-by: Kubilay Kahveci <[email protected]>

* fix: attach weakSetName to property declaration

Signed-off-by: Kubilay Kahveci <[email protected]>

* add a test for nested private methods

Signed-off-by: Kubilay Kahveci <[email protected]>

* add a test with any

Signed-off-by: Kubilay Kahveci <[email protected]>

* Added support for static private fields accessors and methods.

* Added error message for private identifiers used with static decorators. There is no spec to go with this behavior as of yet.

* Fixed emit static bug that used private names outside of classes for initialization in esnext. Fixed issue where nested privates produce incorrect brand check.

* Added tests for private static fields methods and accessors.

* Fixed error messages and tests after merge.

* Accept new baseline.

* Improved duplicate identifier checks for static private class elements.

* Added error when using initializers with private static fields when useDefineForClassFields is not specified and target is esnext.

* Fixed code review issues.

* Removed semantically wrong emit on `useDefineForClassFields:true` with `target:esnext`

* Changed emit for uninitialized private static fields.

* Added runtime error in helper if a static private field is accessed before it was declared.

* Fixed code review comments for private identifier static class elements.

* add debug.assertNever for unknown node type (#53)

* Fixed code review issues.

* Fixed code review issues for private class elements.

* Fixes class shadowing when checking access to a private static class element.

* fix private methods/accessors in class expr inside a loop

* collapse switch case

* fix class name

* simplify getPrivateMethodsAndAccessors

* remove findPreviousAccessorInfo

* lazily create weakSetName identifier

* do not allocate a node if not needed in visitMehodDeclaration (#55)

* Removed all the emit helpers for private identifier methods accessors and modified the existing helpers for get and set fields to do the same job.

* Simplified emit for private identifier class elements.

* do not clone the receiver (#57)

* leave bad code in for #constructor and duplicate private names (#58)

* Added check for WeakSet collision.

* Added error for using a set only accessor.

* update keyof tests and ?? (#62)

* replace ?? with ||

* update keyof tests

* fix emit helpers comments

* produce an error if private field helpers are not up to date

* add tests

* fix setter-only compound assignment

* fix tests

* fix duplicated trailing comments (#64)

* clear receiver pos and setTextRange on helper calls

Co-authored-by: Kubilay Kahveci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants