Add dupe check passing two fingerprints #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciated the addition you made to the gem, @gallois; I hope it gets pulled in. |
|
This is also a feature that I can use. |
|
Hey @gallois. Sorry I've left this hanging for so long. Thanks for the PR 👍. I can understand the desire to add the module method. I'l take a look at it this weekend and work on moving it into the gem. |
|
@gallois thanks for the pull request! |
westonplatter
added a commit
that referenced
this pull request
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my scenario, I save the fingerprints and check for dupes sometime in the future.
I thought that a module method for that would do the trick.