Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/resolve timeout issues #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hotfix/resolve timeout issues #38

wants to merge 2 commits into from

Conversation

cr7boulos
Copy link
Collaborator

This PR resolves timeout issues on #33

@cr7boulos
Copy link
Collaborator Author

Reviewed the docs here: https://pptr.dev/#?product=Puppeteer&version=v2.1.1&show=api-pagegotourl-options
Seems like passing 0 to the timeout property should resolve the issue. I was trying to find a massive html file online to test before and after the change to ensure I fixed the issue but did not have any luck.

@cjroth
Copy link

cjroth commented Jan 4, 2021

Hey, I've applied this change as a patch and I'm still getting the timeout errors. Just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophermllr christophermllr christophermllr approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cr7boulos @cjroth @christophermllr