build: Makefile improvements with skeleton sources #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Explorer09
commented
Mar 30, 2024
Explorer09
commented
- Correct skeleton headers dependencies
- Don't use BUILT_SOURCES for skeleton files
- Let "make mostlyclean" delete "*-flex.h"
Explorer09
force-pushed
the
skel-makefile
branch
from
9b41a30 to
9f182cb
Compare
The '*-flex.h' files are included by skeletons.c and not by other source files. Correct the dependencies in the makefile. (The error was introduced by 3603f03) Signed-off-by: Kang-Che Sung <[email protected]>
Signed-off-by: Kang-Che Sung <[email protected]>
State the dependencies of '*-flex.h' skeleton files properly and avoid the 'BUILT_SOURCES' Automake variable, which often does more harm than good (building files that are not needed for a particular target). (Regression from commit e647249) Also remove a GNU make wildcard function call as it's no longer needed. Signed-off-by: Kang-Che Sung <[email protected]>
These skeleton header files can be easily regenerated. (The things that "mostlyclean" shouldn't delete are files that are more expensive to rebuild, e.g. library archives and linked executables.) Signed-off-by: Kang-Che Sung <[email protected]>
Explorer09
force-pushed
the
skel-makefile
branch
from
9f182cb to
bda3a70
Compare
|
Thanks for this! It's on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.