Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions (Replacing TravisCI) #523

Merged
merged 5 commits into from
May 16, 2022
Merged

Conversation

Mightyjo
Copy link
Contributor

These are the changes from #480 that convert automated builds from Travis CI to Github Actions. A couple of new commits update the scripts to run on Ubuntu 20.04.

I'll rebase and resubmit the release automation change set once this set is settled.

@Mightyjo Mightyjo mentioned this pull request May 11, 2022
@Mightyjo
Copy link
Contributor Author

Mightyjo commented May 11, 2022

The result of the automated build (with distcheck) and CodeQL analysis are above below. I'm awfully glad they succeeded :)

Copy link

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westes westes merged commit 4c0345c into westes:master May 16, 2022
@GitMensch
Copy link
Contributor

That is really a good step forward. It raises two issues though:

  • So far you can't see from the outside if you use a 2.6.4 or a newer ci snapshot. This is because configure.ac still has the version 2.6.4 - can this be adjusted to be 2.6.5-dev, please? This is mostly a question @westes (of course the build could, before "make distcheck" also adjust the version and append something like "ci-$(date -Iminutes)".
  • Can you please add artifacts (something to download)? For builds passing this would be flex*.tar.*.

@Mightyjo
Copy link
Contributor Author

  • So far you can't see from the outside if you use a 2.6.4 or a newer ci snapshot. This is because configure.ac still has the version 2.6.4 - can this be adjusted to be 2.6.5-dev, please? This is mostly a question @westes (of course the build could, before "make distcheck" also adjust the version and append something like "ci-$(date -Iminutes)".
  • Can you please add artifacts (something to download)? For builds passing this would be flex*.tar.*.

Good points! Take a look at #480 from which this was split out. This workflow is mainly to support code review of new PRs. The ones in #480 are close to what you're asking for. I'm looking for discussion there about the use of semantic-release, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants