Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom
tsconfig.json
file are ignored bydi-compiler
, as it uses theget-tsconfig
package to scan for the defaulttsconfig.json
file. For example, if usingtsconfig.test.json
with"di": { "identifier": "myContainer" }
, it will not work becausedi-compiler
will load these settings fromtsconfig.json
(and nottsconfig.test.json
).To resolve this, the arguments passed to the compiler (in
typescript.sys.args
) are checked for the-p
(or--project
) options and the following parameter is used as the typescript filename, which is then provided to theget-tsconfig
methodgetTsconfig
. If the-p
option is not found, it results in undefined, which falls back on the existing defaults to scan for atsconfig.json
file.Ran test suite and all tests pass. Likely the github actions execution will fail again, as my last pull request failed due to a
pnpm
version compatibility issue with the actions (and #28 likely needs to be addressed as well).