Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(modules): ensure relative paths work correctly #1

Open
wants to merge 76 commits into
base: feat/esmodule
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
a99dc52
chore: fix lint task
dignifiedquire May 6, 2017
47e52e4
chore: update contributors
dignifiedquire May 6, 2017
2a847c2
chore: release v1.7.0
dignifiedquire May 6, 2017
b0f41c7
feat(config): remove polling usage
wesleycho May 6, 2017
ec92ea9
feat(ci): disable testing of node versions below 4
wesleycho May 6, 2017
2f8c049
feat(watcher): Debounce autoWatchBatchDelay
danielcompton Feb 8, 2017
0988022
fix(file-list): Stop polluting global environment with core-js
May 8, 2017
4b60513
fix(preprocessor): retry if fs.readFile fails
ywongau May 17, 2017
357d7c0
chore(travis): only update npm in Node<5 and only to npm@3
mgol May 17, 2017
2789bf5
fix(preprocessor): throw if retry fails
ywongau May 24, 2017
a28b4d2
Merge pull request #2715 from mgol/patch-1
dignifiedquire May 28, 2017
87566d1
Merge pull request #2562 from danielcompton/feat-debounce-autowatchba…
dignifiedquire May 28, 2017
be83116
Merge pull request #2690 from JakeChampion/patch-3
dignifiedquire May 28, 2017
7bab4be
chore: update dependencies
wesleycho May 6, 2017
92a8c81
fix(preprocessor): renamed handeFile to readFileCallback
ywongau May 30, 2017
fa9fd3a
Merge pull request #2692 from wesleycho/feat/ci
dignifiedquire Jun 26, 2017
33e53b9
Merge pull request #2693 from wesleycho/feat/polling
dignifiedquire Jun 26, 2017
483bedd
Merge pull request #2689 from wesleycho/chore/deps
dignifiedquire Jun 26, 2017
264442b
feat(deps): update socket.io to `1.7.4` to avoid issue with `ws@1.1.2`
wehriam Jun 26, 2017
545dc05
Merge pull request #2714 from ywonglanecove/fix-crash-on-read-file-error
dignifiedquire Jun 26, 2017
7feaa5c
chore(ci): validate commit message when asked, only run tests once
chrahunt Jul 9, 2017
8c98439
chore(ci): pass expected path to validate-commit-msg
chrahunt Jul 10, 2017
69978ee
Merge pull request #2767 from chrahunt/fix-travis-checks
dignifiedquire Jul 19, 2017
e56861a
test(e2e): fix tests for new cucumber-js
chrahunt Jul 9, 2017
7feaee3
feat(deps): add support for node@8
kellyjensen Jun 29, 2017
15c67c9
chore: normalize @mgols name in .mailmap
mgol Aug 15, 2017
f3e5c7f
Merge pull request #2757 from kellyjensen/master
dignifiedquire Aug 15, 2017
fafa700
Merge pull request #2765 from chrahunt/fix-e2e-tests
dignifiedquire Aug 15, 2017
523d608
feat(client): log global error stack trace
briandipalma Aug 22, 2017
a36f3eb
fix(debug-runner): support asynchronous tests in the debug runner
daanstolp Aug 25, 2017
ea32194
feat(deps): add support for node@8
kellyjensen Jun 29, 2017
66b08e6
chore: update contributors
dignifiedquire Aug 30, 2017
ee40570
chore: release v1.7.1
dignifiedquire Aug 30, 2017
e79463b
feat: update of supported node versions
johnjbarton Sep 6, 2017
0c53a74
Merge branch 'master' into 1.7.1
johnjbarton Oct 19, 2017
da67e50
Merge branch 'master' into 1.7.1
johnjbarton Oct 24, 2017
f32f9e1
chore: update @mgol's name in .mailmap
mgol Oct 25, 2017
c6206a1
test(web-server): fix http2 tests
mgol Oct 25, 2017
c96a7bd
Merge pull request #2855 from mgol/mailmap
dignifiedquire Oct 25, 2017
feadb7b
Merge pull request #2857 from mgol/node8.8-fix
dignifiedquire Oct 25, 2017
e62ed41
Merge pull request #2845 from karma-runner/1.7.1
zzo Nov 9, 2017
c1fcf42
feat(config): allow to use newer versions of CoffeeScript
NeverwinterMoon Nov 1, 2017
5a6725a
Merge pull request #2866 from NeverwinterMoon/master
johnjbarton Nov 13, 2017
ec47d81
fix(config): Workaround npm 5.4 windows bug
johnjbarton Nov 15, 2017
4d4f087
Try appveyor-retry for npm install fail on windows.
johnjbarton Nov 15, 2017
d7a064c
Try appveyor-retry in npm install, not install npm
johnjbarton Nov 15, 2017
17d5791
fix(config): Retry install with appveyor-retry.
johnjbarton Nov 15, 2017
3b7b019
fix(deps): update socket.io to version 2.0.3.
johnjbarton Nov 15, 2017
d7b725c
Merge pull request #2880 from johnjbarton/fix-2777
zzo Nov 15, 2017
0801a7f
feat(cli): Warn on commands with underscores.
johnjbarton Nov 9, 2017
35f03b3
Merge pull request #2871 from johnjbarton/feat-cli-error-check
zzo Nov 16, 2017
3bf3c60
docs(dev): Make the commit message requirements prominent.
johnjbarton Nov 17, 2017
f6f8707
fix(logging): Upgrade to log4js 2.x API. (#2868)
johnjbarton Nov 21, 2017
b8a750a
Merge pull request #2883 from karma-runner/johnjbarton-patch-4
dignifiedquire Nov 21, 2017
0330cd1
feat(middleware): added manual file type option
josh18 Nov 21, 2017
6d353dc
docs: improve comments in config.tpl.*
alesrosina Nov 22, 2017
a340dae
fix(config): Call debug log methods after setting the loglevel based …
Nov 22, 2017
e23c0d4
Merge pull request #2837 from JakeChampion/logs
dignifiedquire Nov 22, 2017
334f9fb
feat(launcher): trim whitespace in browser name
dherges Nov 24, 2017
91e916a
docs(config): Document port collision scenario.
reda-alaoui Nov 25, 2017
7bd54ed
Merge pull request #2890 from reda-alaoui/patch-1
dignifiedquire Nov 25, 2017
99fd3f0
fix(config): Call debug log methods after setting the loglevel based …
Nov 22, 2017
871d46f
feat(launcher): trim whitespace in browser name
dherges Nov 24, 2017
d93cc5f
docs(config): Document port collision scenario.
reda-alaoui Nov 25, 2017
bf25094
chore(deps): update to latest
dignifiedquire Nov 22, 2017
c3ccc5d
chore(ci): focus on even node versions
dignifiedquire Nov 22, 2017
af0efda
test(e2e): update cucumber step definitions
dignifiedquire Nov 22, 2017
0e1907d
test: improve linting and fix test on node 4
dignifiedquire Nov 24, 2017
60dfc5c
feat: drop core-js and babel where possible
dignifiedquire Nov 25, 2017
00e3f88
chore: remove yarn.lock for now
dignifiedquire Nov 25, 2017
10fac07
Merge pull request #2885 from karma-runner/prep-2
dignifiedquire Nov 25, 2017
c9e1ca9
feat: better string representation of errors
macjohnny May 17, 2017
b53929a
Merge pull request #2712 from macjohnny/patch-1
EzraBrooks Nov 27, 2017
75e5423
feat(config): add support for ES modules
wesleycho May 4, 2017
79d9716
test(modules): ensure relative paths work correctly
appsforartists May 4, 2017
fa24808
test(e2e): module-types
appsforartists Nov 21, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(preprocessor): throw if retry fails
ywongau committed May 24, 2017
commit 2789bf57abd977def5caf22609eef74acbad292e
2 changes: 1 addition & 1 deletion lib/preprocessor.js
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ var createPreprocessor = function (config, basePath, injector) {
fs.readFile(file.originalPath, handleFile)
return
} else {
done()
throw err
}
}

10 changes: 5 additions & 5 deletions test/unit/preprocessor.spec.js
Original file line number Diff line number Diff line change
@@ -261,19 +261,19 @@ describe('preprocessor', () => {
thirdCallback('error')
})

it('should abort after 3 retries', (done) => {
it('should tbrow after 3 retries', (done) => {
var injector = new di.Injector([{}, emitterSetting])

var pp = m.createPreprocessor({'**/*.js': []}, null, injector)

pp(file, () => {
done()
})
pp(file, () => { })

getReadFileCallback(0)('error')
getReadFileCallback(1)('error')
getReadFileCallback(2)('error')
getReadFileCallback(3)('error')

expect(() => getReadFileCallback(0)('error')).to.throw('error')
done()
})
})