Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tsed logger error in pdf converter #9559

Open
wants to merge 4 commits into
base: feat/135772-pdf-page-bulk-export
Choose a base branch
from

Conversation

arafubeatbox
Copy link
Contributor

@arafubeatbox arafubeatbox commented Jan 19, 2025

背景

pdf-converter で pdf 変換を実行した時に tsed の logger が tsed/common から読み込めないエラーが生じる。

this.logger.error('Failed to convert html to pdf', err);
^

TypeError: Cannot read properties of undefined (reading 'error')
at PdfConvertService.readHtmlAndConvertToPdfUntilFinish 

(おそらく #9535 の変更でパッケージ解決の方法が変わった

解決方法

最新の logger の使用方法としては個別にパッケージをインストールし、tsed/logger から直接 import するというものが提示されていたため、そちらに倣って修正。
https://tsed.dev/docs/logger.html

task

https://redmine.weseek.co.jp/issues/160491

Copy link

changeset-bot bot commented Jan 19, 2025

⚠️ No Changeset found

Latest commit: cad500b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arafubeatbox arafubeatbox marked this pull request as ready for review January 19, 2025 06:10
@@ -12,7 +12,8 @@
"build": "pnpm gen:client-code && tsc -p tsconfig.json"
},
"dependencies": {
"axios": "^0.24.0"
"axios": "^0.24.0",
"tslib": "^2.8.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-app-launch-dev で tslib のエラーが生じるようになっていたため、明示的に指定

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant