only skip puppeteer init on swagger generation #9528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
#9283 (comment) の FB 対応のための調査の結果、generate-swagger のコマンドではアプリの起動 ($onInit の実行) が避けられないことがわかったため、
は作成するのが難しそう。
詳細)
growi/apps/pdf-converter/src/bin/index.ts
Line 7 in edea8be
で渡した Server が
https://github.com/tsedio/tsed-cli/blob/a18462ea5200690dfb6a3dc42f24a97d6cd5843b/packages/cli-generate-swagger/src/commands/GenerateSwaggerCmd.ts#L62-L68
で起動されている。
実装内容
とりあえず generate-swagger 実行時にエラーの原因となっているのは puppeteer だけなので、スキップする処理を puppeteer に限定
task
https://redmine.weseek.co.jp/issues/159690