Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only skip puppeteer init on swagger generation #9528

Conversation

arafubeatbox
Copy link
Contributor

背景

#9283 (comment) の FB 対応のための調査の結果、generate-swagger のコマンドではアプリの起動 ($onInit の実行) が避けられないことがわかったため、

generate-swagger するためだけのエントリーポイント

は作成するのが難しそう。

詳細)


で渡した Server が
https://github.com/tsedio/tsed-cli/blob/a18462ea5200690dfb6a3dc42f24a97d6cd5843b/packages/cli-generate-swagger/src/commands/GenerateSwaggerCmd.ts#L62-L68
で起動されている。

実装内容

とりあえず generate-swagger 実行時にエラーの原因となっているのは puppeteer だけなので、スキップする処理を puppeteer に限定

task

https://redmine.weseek.co.jp/issues/159690

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 4d3f6ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arafubeatbox arafubeatbox marked this pull request as ready for review December 26, 2024 13:48
@yuki-takei yuki-takei merged commit be9189f into feat/135772-pdf-page-bulk-export Dec 27, 2024
5 checks passed
@yuki-takei yuki-takei deleted the imprv/159235-159690-only-skip-puppeteer-init-on-swagger-gen branch December 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants