Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprv/156177 159580 change pdf converter type to module #9520

Conversation

arafubeatbox
Copy link
Contributor

@arafubeatbox arafubeatbox commented Dec 24, 2024

https://github.com/weseek/growi/pull/9279/files#r1813397949 対応

実装内容

  • pdf-converter の type を module に変更
  • ts.ed を esm only な最新の v8 にアップデート

動作確認

pdf エクスポートができることを確認

task

https://redmine.weseek.co.jp/issues/159580

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 4bd0bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"start:prod:ci": "pnpm start:prod --ci",
"start:prod": "node dist/index.js",
"lint": "pnpm eslint **/*.{js,ts}",
"gen:swagger-spec": "SWAGGER_GENERATION=true tsed run generate-swagger --output ./specs",
"gen:swagger-spec": "SWAGGER_GENERATION=true node --import @swc-node/register/esm-register src/bin/index.ts generate-swagger --output ./specs",
Copy link
Contributor Author

@arafubeatbox arafubeatbox Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsed run だとバグがあり、エラーが生じるようになってしまったが、内部実装を確認するとただのエイリアスコマンドであり、実行している内容は node --import @swc-node/register/esm-register src/bin/index.ts だったため、直接そちらを書くように変更。

@tsed/cli は依存するパッケージの量も多いため、generate-swagger のみを実行する場合、こちらの方が軽くて良さげ。

"ignore": ["node_modules/**/*"],
"delay": 100,
"execMap": {
"ts": "node --import @swc-node/register/esm-register"
Copy link
Contributor Author

@arafubeatbox arafubeatbox Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev での ts の実行に swc-node を使うように変更

@arafubeatbox arafubeatbox marked this pull request as ready for review December 24, 2024 11:57
@yuki-takei yuki-takei merged commit edea8be into feat/135772-pdf-page-bulk-export Dec 25, 2024
14 of 16 checks passed
@yuki-takei yuki-takei deleted the imprv/156177-159580-change-pdf-converter-type-to-module branch December 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants