Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprv/159233 159234 show warning on page bulk export exec #9499

Conversation

arafubeatbox
Copy link
Contributor

@arafubeatbox arafubeatbox commented Dec 18, 2024

イメージ

before

image

after

image

task

https://redmine.weseek.co.jp/issues/159234

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 1fbac73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -33,10 +33,6 @@ export interface IPageBulkExportService {

class PageBulkExportService implements IPageBulkExportService {

// temporal path of local fs to output page files before upload
// TODO: If necessary, change to a proper path in https://redmine.weseek.co.jp/issues/149512
tmpOutputRootDir = '/tmp/page-bulk-export';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page-bulk-export-cron に移行され、消し忘れ

@arafubeatbox arafubeatbox marked this pull request as ready for review December 18, 2024 14:26
@yuki-takei yuki-takei merged commit 64c8e1e into feat/page-bulk-export Dec 20, 2024
10 checks passed
@yuki-takei yuki-takei deleted the imprv/159233-159234-show-warning-on-page-bulk-export-exec branch December 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants