support: add migration file #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
Jan 23, 2023
| const tsvReplaced = plantUmlReplaced.replace(oldTsvTableRegExp, '``` tsv$1\n$2\n```'); | ||
| const csvReplaced = tsvReplaced.replace(oldCsvTableRegExp, '``` csv$1\n$2\n```'); | ||
| return csvReplaced; | ||
| } |
There was a problem hiding this comment.
こういうことではないなあ
理想
TypeScript 風に書くと、
replaceLatestRevisions(processor: Processor[]) {
// replacer の数だけ body.replace する
}
Processor は (markdown: string) => string
利点
- グループ別に「これは差し替えたい」「これはスキップしたい」といったユーザー要望があるはず
- グループ1: drawio, plantuml 等
- グループ2: GROWI 独自 syntax の linker
- 将来的に、ユーザーが入れられると一番強い
yuki-takei
requested changes
Jan 23, 2023
packages/app/migration.sh
Outdated
| var oldCsvTableRegExp = /::: csv(-h)?\n([\s\S]*?)\n:::/g; // CSVによるテーブル描画の旧記法 | ||
|
|
||
| function replaceBody(body) { | ||
| const drawioReplaced = body.replace(oldDrawioRegExp, '```drawio\n$1\n```'); |
packages/app/migration.sh
Outdated
| var pagesCollection = db.getCollection("pages"); | ||
| var revisionIds = []; | ||
|
|
||
| // 各ページの最新のrevisionを取得(最新revisionしか記法のマイグレーションをしない) |
packages/app/migration.sh
Outdated
| if (doc.revision != undefined) { | ||
| revisionIds.push(doc.revision); | ||
| } | ||
| }); |
There was a problem hiding this comment.
パフォーマンス的に NG。ページが10万とかあったらどうするのだ。
There was a problem hiding this comment.
100ページごと、最新のrevisionを置き換える形にしました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/112439
GROWIv6へのリリースガイド
v6へのアップグレードに際する上記の3つの記法変更に対応するためのマイグレーションの
mongoshellのスクリプトを書きました動作確認
上記のすべてにおいてマイグレーション後、v6で正常に表示できることを確認しました。