Skip to content

Commit

Permalink
Downgrade and pin the bytelines crate (dandavison#1378)
Browse files Browse the repository at this point in the history
The versions 2.3+ added support for Tokio's `AsyncBufRead` trait and
futures' `Stream` trait without making the new dependencies optional.

 By downgrading `bytelines`, the compilation time can be reduced.

```
$ cargo up -p bytelines --precise 2.2.2
    Updating bytelines v2.4.0 -> v2.2.2
    Removing bytes v1.4.0
    Removing futures v0.3.26
    Removing futures-channel v0.3.26
    Removing futures-core v0.3.26
    Removing futures-executor v0.3.26
    Removing futures-io v0.3.26
    Removing futures-macro v0.3.26
    Removing futures-sink v0.3.26
    Removing futures-task v0.3.26
    Removing futures-util v0.3.26
    Removing pin-project-lite v0.2.9
    Removing pin-utils v0.1.0
    Removing slab v0.4.8
    Removing tokio v1.26.0
```
  • Loading branch information
nickelc authored Apr 26, 2023
1 parent d89b357 commit 12fd54e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 136 deletions.
137 changes: 2 additions & 135 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ansi_term = "0.12.1"
atty = "0.2.14"
bitflags = "2.2.1"
box_drawing = "0.1.2"
bytelines = "2.4.0"
bytelines = "=2.2.2" # Pin version until its tokio and futures dependencies are optional.
clap = { version = "4.1.8", features = ["derive", "help", "usage", "error-context", "wrap_help"] }
console = "0.15.0"
ctrlc = "3.2.5"
Expand Down

0 comments on commit 12fd54e

Please sign in to comment.