Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Style with Expanded Italics Scope for 'Italicsify for Operator Mono' #251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dylandifilippo
Copy link

Proposed changes

I added some settings to extends the scope of "Italicsify for Operator Mono". In my opinion it makes the theme even better.

If the pull request addresses a specific issue or feature request, be sure to reference it here by linking to the relevant issue.

Screenshots

Include screenshots to demonstrate the changes made by this pull request. This include before-and-after comparisons or specific examples of the modified functionality.

Before

CleanShot 2024-04-30 at 11 29 53@2x

After

CleanShot 2024-04-30 at 14 56 47@2x

Checklist

Before submitting this pull request, ensure that you have completed the following tasks:

(Put an x in the boxes that apply.)

  • [ x] I have read and understood the CONTRIBUTING guidelines.
  • [ x] I have performed a self-review of my code.
  • [ x] I have added relevant screenshots or visual aids to showcase the changes made by this pull request.

@wesbos
Copy link
Owner

wesbos commented Apr 30, 2024

hmmm I tihnk this is a bit much, but it would be cool to have a setting to turn them on.

That, or add this to the docs on how to add this settings to your own settings.json file

@dylandifilippo
Copy link
Author

Thanks for the reply.

I will remove those changes from the code and add a little guide to the doc. It will be the most convenient solution.

@dylandifilippo
Copy link
Author

@wesbos Let me know if it is ok for you now 😊

@dylandifilippo
Copy link
Author

@wesbos How can I add reviewers ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants