Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nic chile #154

Closed
wants to merge 3 commits into from
Closed

Update nic chile #154

wants to merge 3 commits into from

Conversation

silva96
Copy link

@silva96 silva96 commented Jan 11, 2023

closes #109

@jarthod
Copy link

jarthod commented Jan 16, 2023

Thanks for this @silva96, for the record this project isn't really maintained by @weppos any more, so I ended up starting my fork in which I merged many of the pending PRs. I try to keep it maintained in hope it could be merged back upstream some day so everyone can benefit from it. I did not cherry-pick your PR here because it was lacking proper updates to the rest of the parser (which was still broken) and also not providing acurate tests. But I did write a complete update of this parser in 0880e37. So if you need this (and many other fixes) you can use my fork in the meantime:

gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

@silva96
Copy link
Author

silva96 commented Jan 16, 2023

Great! @jarthod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.cl (Chile) not correctly parsed
2 participants