Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extend metric registry to allow metric slices to be used. Prior to this change metric registry only alowed arrays. Slices are treated identical to the arrays -- the values are expanded, and each metric added to the registry. The array itself was not added. From some historical archeological perspective, cockroachdb#46747 added support for embedded metric Arrays. My best read on this PR is that it narrowly addressed the existing "TODOs", and avoided doing anything extra (which is good!). But it does not appear that there is a fundamental reason why slices should not be supported the same way. Expic: None Release note: None # Conflicts: # pkg/util/metric/registry.go # pkg/util/metric/registry_test.go
- Loading branch information