Merge cockroachdb#84441

84441: ppc64le - fix geoindex/TestS2GeometryIndexBasic failure r=otan a=prashantkhoje Related cockroachdb#82456 Release note: None Co-authored-by: Prashant Khoje <[email protected]>
wenyihu6 · Jul 17, 2022 · dc382b1 · dc382b1
2 parents e4cafeb + 00734a8
commit dc382b1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/geo/geo.go b/pkg/geo/geo.go
@@ -756,9 +756,11 @@ func IsLinearRingCCW(linearRing *geom.LinearRing) bool {
 	b := smallest
 	c := linearRing.Coord(nextIdx)
 
-	areaSign := a.X()*b.Y() - a.Y()*b.X() +
-		a.Y()*c.X() - a.X()*c.Y() +
-		b.X()*c.Y() - c.X()*b.Y()
+	// Explicitly use float64 conversion to disable "fused multiply and add" (FMA) to force
+	// identical behavior on all platforms. See https://golang.org/ref/spec#Floating_point_operators
+	areaSign := float64(a.X()*b.Y()) - float64(a.Y()*b.X()) + // nolint:unconvert
+		float64(a.Y()*c.X()) - float64(a.X()*c.Y()) + // nolint:unconvert
+		float64(b.X()*c.Y()) - float64(c.X()*b.Y()) // nolint:unconvert
 	// Note having an area sign of 0 means it is a flat polygon, which is invalid.
 	return areaSign > 0
 }