kvserver/rangefeed: remove non-mux rangefeed metrics

Previously, we removed non-mux rangefeed code in
cockroachdb#125610. However, that patch forgot
to remove non-mux rangefeed metrics. This patch removes these metrics as they
are no longer needed.

Epic: none
Release note: none

docs/generated/metrics/metrics.html

@@ -629,8 +629,6 @@
 <tr><td>STORAGE</td><td>rpc.method.writebatch.recv</td><td>Number of WriteBatch requests processed</td><td>RPCs</td><td>COUNTER</td><td>COUNT</td><td>AVG</td><td>NON_NEGATIVE_DERIVATIVE</td></tr>
 <tr><td>STORAGE</td><td>rpc.streams.mux_rangefeed.active</td><td>Number of currently running MuxRangeFeed streams</td><td>Streams</td><td>GAUGE</td><td>COUNT</td><td>AVG</td><td>NONE</td></tr>
 <tr><td>STORAGE</td><td>rpc.streams.mux_rangefeed.recv</td><td>Total number of MuxRangeFeed streams</td><td>Streams</td><td>COUNTER</td><td>COUNT</td><td>AVG</td><td>NON_NEGATIVE_DERIVATIVE</td></tr>
-<tr><td>STORAGE</td><td>rpc.streams.rangefeed.active</td><td>Number of currently running RangeFeed streams</td><td>Streams</td><td>GAUGE</td><td>COUNT</td><td>AVG</td><td>NONE</td></tr>
-<tr><td>STORAGE</td><td>rpc.streams.rangefeed.recv</td><td>Total number of RangeFeed streams</td><td>Streams</td><td>COUNTER</td><td>COUNT</td><td>AVG</td><td>NON_NEGATIVE_DERIVATIVE</td></tr>
 <tr><td>STORAGE</td><td>spanconfig.kvsubscriber.oldest_protected_record_nanos</td><td>Difference between the current time and the oldest protected timestamp (sudden drops indicate a record being released; an ever increasing number indicates that the oldest record is around and preventing GC if &gt; configured GC TTL)</td><td>Nanoseconds</td><td>GAUGE</td><td>NANOSECONDS</td><td>AVG</td><td>NONE</td></tr>
 <tr><td>STORAGE</td><td>spanconfig.kvsubscriber.protected_record_count</td><td>Number of protected timestamp records, as seen by KV</td><td>Records</td><td>GAUGE</td><td>COUNT</td><td>AVG</td><td>NONE</td></tr>
 <tr><td>STORAGE</td><td>spanconfig.kvsubscriber.update_behind_nanos</td><td>Difference between the current time and when the KVSubscriber received its last update (an ever increasing number indicates that we&#39;re no longer receiving updates)</td><td>Nanoseconds</td><td>GAUGE</td><td>NANOSECONDS</td><td>AVG</td><td>NONE</td></tr>

pkg/server/node.go

@@ -191,18 +191,6 @@ This metric is thus not an indicator of KV health.`,
 		Measurement: "Bytes",
 		Unit:        metric.Unit_BYTES,
 	}
-	metaActiveRangeFeed = metric.Metadata{
-		Name:        "rpc.streams.rangefeed.active",
-		Help:        `Number of currently running RangeFeed streams`,
-		Measurement: "Streams",
-		Unit:        metric.Unit_COUNT,
-	}
-	metaTotalRangeFeed = metric.Metadata{
-		Name:        "rpc.streams.rangefeed.recv",
-		Help:        `Total number of RangeFeed streams`,
-		Measurement: "Streams",
-		Unit:        metric.Unit_COUNT,
-	}
 	metaActiveMuxRangeFeed = metric.Metadata{
 		Name:        "rpc.streams.mux_rangefeed.active",
 		Help:        `Number of currently running MuxRangeFeed streams`,
@@ -270,8 +258,6 @@ type nodeMetrics struct {
 	CrossRegionBatchResponseBytes *metric.Counter
 	CrossZoneBatchRequestBytes    *metric.Counter
 	CrossZoneBatchResponseBytes   *metric.Counter
-	NumRangeFeed                  *metric.Counter
-	ActiveRangeFeed               *metric.Gauge
 	NumMuxRangeFeed               *metric.Counter
 	ActiveMuxRangeFeed            *metric.Gauge
 }
@@ -293,8 +279,6 @@ func makeNodeMetrics(reg *metric.Registry, histogramWindow time.Duration) nodeMe
 		CrossRegionBatchResponseBytes: metric.NewCounter(metaCrossRegionBatchResponse),
 		CrossZoneBatchRequestBytes:    metric.NewCounter(metaCrossZoneBatchRequest),
 		CrossZoneBatchResponseBytes:   metric.NewCounter(metaCrossZoneBatchResponse),
-		ActiveRangeFeed:               metric.NewGauge(metaActiveRangeFeed),
-		NumRangeFeed:                  metric.NewCounter(metaTotalRangeFeed),
 		ActiveMuxRangeFeed:            metric.NewGauge(metaActiveMuxRangeFeed),
 		NumMuxRangeFeed:               metric.NewCounter(metaTotalMuxRangeFeed),
 	}