[bin] support model saving for both per-step & per-epoch mode #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robin1001
reviewed
Dec 19, 2023
| @@ -76,19 +78,35 @@ def train(self, model, optimizer, scheduler, data_loader, writer, configs, | |||
| info_dict = update_parameter_and_lr(model, optimizer, | |||
| scheduler, scaler, | |||
| info_dict) | |||
| save_interval = info_dict.get('save_interval', 10000) | |||
There was a problem hiding this comment.
just like log_interval, save_interval is set in train.yaml?
There was a problem hiding this comment.
这里我认为 ： log save_interval等为训练行为 应该放到train的args里边
There was a problem hiding this comment.
是的，都在train.yaml, 需要的话可以改到args
robin1001
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1839