[CIF] Deal With Replicate Codes #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MrSupW
commented
Mar 14, 2023
MrSupW
commented
- reuse the MHA class of wenet/transformer/attention.py
- reuse the DecoderLayer class of wenet/transformer/decoder_layer.py
- reuse the make_pad_mask method of wenet/utils/mask.py
- reuse the PositionalEncoding class of wenet/transformer/embeddings.py
robin1001
reviewed
Mar 15, 2023
| MultiHeadedAttentionSANMDecoder, MultiHeadedAttentionCrossAtt | ||
| from wenet.cif.decoder_layer import DecoderLayer, DecoderLayerSANM | ||
| from wenet.cif.embedding import PositionalEncoding | ||
| from wenet.utils.mask import make_pad_mask |
There was a problem hiding this comment.
please sort the import order by alphabet
robin1001
reviewed
Mar 15, 2023
|
|
||
| return mask | ||
|
|
||
|
|
||
| def sequence_mask(lengths, maxlen: Optional[int] = None, |
There was a problem hiding this comment.
sequence_mask has the same function with subsequent_mask in utisl/mask.py, we can reuse it.
robin1001
approved these changes
Mar 15, 2023
|
I add some comments, we can refine it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.