Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test the Pruning of Unused Definitions for Its Updated Phase in Metaschema Composition Pipeline #10

Conversation

aj-stein-nist
Copy link

@aj-stein-nist aj-stein-nist commented Apr 7, 2022

Committer Notes

As part of usnistgov#198 and to ease collaboration with Wendell in usnistgov#199 to then package and combine our work into a final merge.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist changed the base branch from master to issue196-definition-pruning-enhancement April 7, 2022 16:49
@aj-stein-nist
Copy link
Author

@wendellpiez, I finally got it working! haha. For now, I check for the exsitence of only 1 EXCEPTION which we are talking to adapt or redesign for debug logging around <EXCEPTION>Seeing ...</EXCEPTION> logging that is not technically an exception. I will build out some more logic throughout the day.

@aj-stein-nist aj-stein-nist force-pushed the issue-196-definition-pruning-enhancements-test branch from c7ac6a7 to 098143c Compare April 8, 2022 19:16
@wendellpiez wendellpiez marked this pull request as ready for review April 8, 2022 19:34
@wendellpiez wendellpiez merged commit 727a4c7 into wendellpiez:issue196-definition-pruning-enhancement Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants