Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify big.Int to hexutil.Big #93

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: modify big.Int to hexutil.Big #93

merged 1 commit into from
May 30, 2024
+30 −12

Conversation

eomti-wm
Copy link

  • The return type of the API method for getting Brioche configuration has been modified from big.Int to hexutil.Big.

egonspace
egonspace approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace added the enhancement New feature or request label May 30, 2024
@eomti-wm eomti-wm merged commit 60df0bd into dev May 30, 2024
5 checks passed
@eomti-wm eomti-wm deleted the fix/brioche-api branch May 30, 2024 06:01
This was referenced May 31, 2024
Merged
Merged
@egonspace egonspace mentioned this pull request Sep 11, 2024
Merged
@jennwiederholen jennwiederholen mentioned this pull request Sep 11, 2024
Merged
@jennwiederholen jennwiederholen mentioned this pull request Sep 19, 2024
Merged
This was referenced Oct 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonspace egonspace egonspace approved these changes

@kai-yu-wm kai-yu-wm kai-yu-wm approved these changes

@jed-wemade jed-wemade jed-wemade approved these changes

@felix-shin-wt felix-shin-wt Awaiting requested review from felix-shin-wt

@freddie-kim-wt freddie-kim-wt Awaiting requested review from freddie-kim-wt

@Noah-jhkim Noah-jhkim Awaiting requested review from Noah-jhkim

@jennwiederholen jennwiederholen Awaiting requested review from jennwiederholen

@paul-ahn-wm paul-ahn-wm Awaiting requested review from paul-ahn-wm

Assignees

@eomti-wm eomti-wm

Labels
enhancement New feature or request
Projects
No open projects
Brioche Hardfork
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eomti-wm @egonspace @kai-yu-wm @jed-wemade