Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename Migrator before and after methods #83

Merged
merged 1 commit into from
May 17, 2020
Merged

rename Migrator before and after methods #83

merged 1 commit into from
May 17, 2020

Conversation

skarzi
Copy link
Collaborator

@skarzi skarzi commented May 17, 2020

Rename Migrator methods:

  • before to apply_initial_migration
  • after to apply_tested_migration

Closes #10

@skarzi
rename Migrator before and after methods
09952fd 
Rename ``Migrator`` methods:

+ ``before`` to ``apply_initial_migration``
+ ``after`` to ``apply_tested_migration``
@skarzi skarzi requested a review from sobolevn May 17, 2020 10:22
@skarzi skarzi self-assigned this May 17, 2020
@codecov
Copy link

codecov bot commented May 17, 2020 •
edited
Loading

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          189       189           
  Branches        19        19           
=========================================
  Hits           189       189
Impacted Files Coverage Δ
django_test_migrations/contrib/unittest_case.py 100.00% <100.00%> (ø)
django_test_migrations/migrator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7aeb32...09952fd. Read the comment docs.

@sobolevn sobolevn merged commit 066a323 into master May 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-10 branch May 17, 2020 10:30
@sobolevn
Copy link
Member

Let's merge #69 and release 1.0
What do you think?

@sobolevn
Copy link
Member

Btw, thanks a lot for working on this project! 👍
Really appreciated!

@skarzi
Copy link
Collaborator Author

skarzi commented May 17, 2020 •
edited
Loading

That's good idea 👍

I am also slowly working on #47, but it can be released later

@skarzi skarzi mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

@skarzi skarzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing before/after methods.
2 participants
@skarzi @sobolevn