Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AnyConnection type for django > 3.1 #154

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

skarzi
Copy link
Collaborator

@skarzi skarzi commented Dec 14, 2020

No description provided.

@skarzi skarzi self-assigned this Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #154 (17815bd) into master (403b664) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        17    -1     
  Lines          329       319   -10     
  Branches        34        34           
=========================================
- Hits           329       319   -10     
Impacted Files Coverage Δ
django_test_migrations/sql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403b664...17815bd. Read the comment docs.

@skarzi skarzi requested a review from sobolevn December 15, 2020 08:29
@sobolevn
Copy link
Member

Thanks!

What else is required before the release?

@sobolevn sobolevn merged commit 2ae65f3 into master Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/adjust-to-django-master branch December 15, 2020 09:12
@skarzi
Copy link
Collaborator Author

skarzi commented Dec 15, 2020

What else is required before the release?

I think only some more tests on real-life projects. So far, I had tested master branch with several projects, but only with django > 3.0.
Let's wait until Monday with the release, so I can check django-test-migrations on more projects

@skarzi
Copy link
Collaborator Author

skarzi commented Dec 21, 2020

@sobolevn I have tested django-test-migration on few quite big projects (django==1.11 and django==3.1, both with PostgreSQL DB), and everything worked like before so I guess now, we can release a new version and wait for feedback from others

@sobolevn
Copy link
Member

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants