-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(plugins): add FIGlet plugin #12
Conversation
Thank you so much! This looks promising. If you would like to fix the failed check, you need to add the new Do not do this manually; the instructions on how to do this are in the docs. I can do this myself when I review it; up to you! |
Thanks for adding the dependency. The docs were missing a step; that's why the build was still failing. I pushed a fix to the branch and also updated the docs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 385 416 +31
=========================================
+ Hits 385 416 +31 ☔ View full report in Codecov by Sentry. |
I've noticed some fonts add one or even two newlines before the actual ascii art. For example, the We could probably trim the fully empty (only whitespace) lines before returning the output. I can take care of this, if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some final touches this will be ready for merge! Thanks~
I've done this in the new function |
Thank you for your hard work!!! 🫶 |
Summary
Adds plugin "figlet". Allows user to creats an ASCII art representation of a text using characters (letters, numbers, and symbols).
Related issue
--- gitMogged, bye bye.
How has this been tested?
Type of change
Checklist