Add year, journal in preprocess mesh #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsorros
requested review from
aCampello,
ArneRobben,
ivyleavedtoadflax and
pdan93
nsorros
force-pushed
the
add-year-journal
branch
from
5e0693b to
a2e66cf
Compare
nsorros
force-pushed
the
add-year-journal
branch
from
3baa36e to
c5ddd9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both #173 and #160 require a subset of the data to train. The best possible way to provide that subset is to filter by years which is standard practice in this problem. At the moment this is implemented in both PR mentioned but this aims to resolve it for both.
Fixes #109
Checklist